Adjust logback outfile file upon startup #4823
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you clarify how this matches or bypasses #4680? |
|
@lefou This doesn't do anything for #4680. It's more a follow-up of #3530. Before this PR, if any library used by the build logs with slf4j, the log output goes to I stumbled upon that by working on #4800, even though it doesn't need this anymore. |
|
Still a draft, as I'd like to add a non-regression test for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If anything in Mill logs with slf4j, logback is in charge of handling those logs. If ever the Mill out directory is customized, we need to adjust the logback log file location too, so that logs aren't written to the default
out/mill.log.