Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are the PyPi wheels built with CUDA? #187

Open
pbsds opened this issue Oct 3, 2023 · 5 comments
Open

Are the PyPi wheels built with CUDA? #187

pbsds opened this issue Oct 3, 2023 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@pbsds
Copy link

pbsds commented Oct 3, 2023

This section of the readme is not clear about this

pycolmap/README.md

Lines 69 to 72 in 05abbd0

PyCOLMAP can leverage the GPU for feature extraction, matching, and multi-view stereo if COLMAP was compiled with CUDA support.
Similarly, PyCOLMAP can run Delauney Triangulation if COLMAP was compiled with CGAL support.
This requires to build the package from source and is not available with the PyPI wheels.

We know it is not built with CGAL, but CUDA is not clearly said if it supported on PyPI, and if it is, which version? CUDA 10? CUDA 11?

@sarlinpe
Copy link
Member

sarlinpe commented Oct 3, 2023

PyPI wheels are not built with CUDA support at the moment. You are very welcome to help us support it. Some pointers:

  • We'd need to install the Cuda toolkit in the CenOS manylinux image, either through yum (here is a good starting point) or via pip (described here)
  • It would be nice to not package the Cuda libs in the wheel and instead depend on Cuda pip packages - we'd need to add these requirements to the pycolmap wheels.
  • I don't know whether we need to build a separate wheel for each version of Cuda

@sarlinpe sarlinpe added the help wanted Extra attention is needed label Oct 3, 2023
@pbsds
Copy link
Author

pbsds commented Oct 3, 2023

I think the pytorch way, where a MAJOR.MINOR.PATCH+LOCAL scheme where LOCAL is e.g. cuda11 probably is the way to go. I'm not asking for you to dist cuda wheel, but I am hoping for you to clarify the state on PyPi in the README. 😄

@sarlinpe
Copy link
Member

sarlinpe commented Oct 9, 2023

Good point, fixed by #188.

@Phil26AT
Copy link
Collaborator

Phil26AT commented Oct 9, 2023

Just a note: The pycolmap conda wheels are built with CUDA.

@sarlinpe
Copy link
Member

sarlinpe commented Oct 9, 2023

Indeed, the build repo is here: https://github.com/conda-forge/pycolmap-feedstock I am not familiar with the conda build CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants