Refactor post_authors indexer to avoid repeated calls to the catalog

[ericof]

Fix #56

[ericof]

Good call, I will update the PR

…

On Thu, Feb 1, 2024, 18:36 David Glick ***@***.***> wrote: ***@***.**** requested changes on this pull request. ------------------------------ In src/collective/blog/indexers/post.py <#57 (comment)> : > @@ -15,12 +15,7 @@ def post_authors(obj: Post): """Returns the authors of a blog post.""" authors = [] uids = obj.creators - for uid in uids: - searchResult = api.content.find(portal_type="Author", UID=uid) - if len(searchResult) > 0: - author = searchResult[0].getObject() - - if author is not None: - authors.append(author.title) - + brains = api.content.find(portal_type="Author", UID=uids) + for brain in brains: + authors.append(brain.title) The catalog metadata has Title capitalized: ⬇️ Suggested change - authors.append(brain.title) + authors.append(brain.Title) — Reply to this email directly, view it on GitHub <#57 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACKWXQDF4PC3RNSV7M46JLYRQDEDAVCNFSM6AAAAABCVBHBVKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNJXGY4DKMZUGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[jnptk]

I tested it locally and the upgrade step was broken, pushed a fix.

[jnptk]

LGTM

[davisagli]

@jonaspiterek thanks, good catch