-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow a Blog Post to be created inside a subfolder of a Blog #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericof @jonaspiterek Thank you. Could I have a new release with this included, please?
> | ||
<genericsetup:upgradeDepends | ||
title="Blog type: Disallow creation outsite a Blog Folder" | ||
import_steps="rolemap" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericof @jonaspiterek FYI, when I ran this upgrade step on DLR staging, it wiped out the customization that we did to the "Add Blog" permission roles for DLR. I'll take care of it but we need to be more careful with upgrades to the rolemap, and only make the specific change that is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davisagli Interesting point, in this case we needed to reset the permissions for existing installations (otherwise a Blog Post could be added anywhere)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericof Yes I see, it couldn't be avoided in this case.
blog_path = "/".join(blog.getPhysicalPath()) | ||
for permission_id, roles in PERMISSIONS_BLOG: | ||
blog.manage_permission(permission_id, roles=roles, acquire=False) | ||
_log_permission_change(blog_path, permission_id, roles) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no upgrade step to set the "Add Post" permission for existing blogs. So, I'll need to add one for DLR...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davisagli I missed this one... So obvious.
Closes #54