Refactor post_authors indexer to avoid repeated calls to the catalog (#…

…57) * Refactor post_authors indexer to avoid repeated calls to the catalog * Update src/collective/blog/indexers/post.py Co-authored-by: David Glick <david@glicksoftware.com> * fix upgrade steps --------- Co-authored-by: Jonas Piterek <110389276+jonaspiterek@users.noreply.github.com> Co-authored-by: David Glick <david@glicksoftware.com> Co-authored-by: jonaspiterek <piterek@kitconcept.com>
collective · Feb 2, 2024 · f3c7a2d · f3c7a2d
1 parent 2a534ea
commit f3c7a2d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/news/56.bugfix b/news/56.bugfix
@@ -0,0 +1 @@
+Refactor post_authors indexer to avoid repeated calls to the catalog
diff --git a/src/collective/blog/indexers/post.py b/src/collective/blog/indexers/post.py
@@ -15,12 +15,7 @@ def post_authors(obj: Post):
     """Returns the authors of a blog post."""
     authors = []
     uids = obj.creators
-    for uid in uids:
-        searchResult = api.content.find(portal_type="Author", UID=uid)
-        if len(searchResult) > 0:
-            author = searchResult[0].getObject()
-
-            if author is not None:
-                authors.append(author.title)
-
+    brains = api.content.find(portal_type="Author", UID=uids)
+    for brain in brains:
+        authors.append(brain.Title)
     return authors
diff --git a/src/collective/blog/upgrades/configure.zcml b/src/collective/blog/upgrades/configure.zcml
@@ -63,7 +63,7 @@
         />
     <genericsetup:upgradeDepends
         title="Blog type: Set global_allow to true"
-        import_steps="types"
+        import_steps="typeinfo"
         />
   </genericsetup:upgradeSteps>
 </configure>
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Refactor post_authors indexer to avoid repeated calls to the catalog