Depend on the cargo-ament-build Python wheel

[esteve]

No description provided.

[esteve]

This should fail now because the cargo-ament-build PyPI wheel is not uploaded yet.

[luca-della-vedova]

If we are installing cargo-ament-build from Pypi, should we remove the action step that installs it manually from cargo?

[esteve]

@luca-della-vedova yeah, that makes sense

[esteve]

@luca-della-vedova whoa, maturin is magic:

https://pypi.org/project/cargo-ament-build/

[esteve]

Looks like CI is failing because the cargo-ament-build wheel is only available for Python 3.8+ and the colcon CI requires Ubuntu 20.04 and Python 3.6 for one of the targets. @cottsay is there a way to provide a custom strategy.json file or should I just override the matrix.os? I tried putting a stategy.json file in different places but it doesn't seem to work. Thanks

[luca-della-vedova]

Hi @esteve

This is really good stuff, thanks a lot! We can use matrix-filter for that purpose, I opened a PR to your branch that introduces it to remove Ubuntu 20.04, it also removes the vendored action since it was introduced purely to install cargo-ament-build through cargo, but this is not needed anymore so we can just rely on the upstream workflow.
You need to approve my action to your repo since I'm a first time contributor, but a run of that branch on my own fork shows green CI and Ubuntu 20.04 being skipped so I'm pretty confident it will be ok

[esteve]

@luca-della-vedova awesome, thank you!

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@a1c4900). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage        ?   62.11%           
=======================================
  Files           ?        8           
  Lines           ?      388           
  Branches        ?       50           
=======================================
  Hits            ?      241           
  Misses          ?      138           
  Partials        ?        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.