-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
DATA-34 Unnest Catalog V2 DataFrames
This MR lets catalog v2 dataframes be unnested and simplifies the CatalogV2 dataframe code. **Background in addition to JIRA ticket details** For Catalog V1, our approach to returning catalogs involved creating a separate data type for each catalog. This resulted in several instances of redundant code and made it expanding upon each new catalog data type laborious. For Catalog V2, we'll generalize all catalog returns as a single data type and account for the differences in structure across endpoint in how the CatalogV2DataCollection object is passed. **Potential breaking changes** Code that manually explode catalog v2 dataframes, specifically relying on referencing specific columns such as `frequencies` and `metrics` columns, will break. They are being replaced by their singular terms to represent the individual rows that are being unnested from those fields. Having said that, catalog v2 dataframes were not all that useful in their current state and were in an experimental stage, so I think it's fine to introduce this change. **Tests** To test the functionality of this code, each catalog v2 endpoint was called as a dataframe and list then matched against the expected fields.
- Loading branch information
1 parent
1f71246
commit 6261653
Showing
4 changed files
with
541 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.