Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMake based build support on master #217

Closed
wants to merge 1,810 commits into from
Closed

Conversation

Mizux
Copy link

@Mizux Mizux commented Apr 17, 2019

No description provided.

@ycollet
Copy link

ycollet commented May 6, 2019

And what about this project ?
https://github.com/ycollet/coinor-cmake/

@Mizux
Copy link
Author

Mizux commented May 6, 2019

Didn't know about it, need to check...

But why not integrating CMake files directly in each repository ?

Also it's seems to be based on Cbc complete source tarball than the nowadays github split layout (e.g. coin-or/CoinUtils ...)

And doc seems out of sync
e.g. https://github.com/ycollet/coinor-cmake/blame/master/README.md#L29-L41
Still on Cbc 2.9.9 (also prefer to use cmake --build build to be portable (e.g. windows using VS generator you wont have any Makefile...))

@ycollet
Copy link

ycollet commented May 6, 2019

You can still compile the Cbc repo using the old way:

# Compiling using git repo:

$ git clone https://github.com/ycollet/coinor-cmake.git
$ git clone https://github.com/coin-or/CoinMP.git
$ cd CoinMP
$ git clone https://github.com/coin-or-tools/BuildTools/
$ BuildTools/get.dependencies.sh fetch
$ cp -r ../coinor-cmake/CoinMP .
$ mkdir build
$ cd build
$ cmake -DCMAKE_INSTALL_PREFIX=/opt/coinmp-devel -DCMAKE_BUILD_TYPE=RELEASE ..
$ make

@Mizux
Copy link
Author

Mizux commented May 6, 2019

The problem is your script is not windows friendly nor this process is Linux distro package ready IMHO.

Please note this PR is part of this coin-or/CoinUtils#101 (with the same concerns etc...)

@svigerske
Copy link
Member

As a side-note: The get.dependencies.sh in BuildTools will go away sooner or later. The script is now called coinbrew and lives in https://github.com/coin-or/coinbrew/

@tkralphs tkralphs closed this Apr 30, 2020
@Mizux Mizux changed the title Add CMake support Add CMake based build support on master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants