Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delivery of compatibility for Flake8 from version 4 to the latest ver… #4
Delivery of compatibility for Flake8 from version 4 to the latest ver… #4
Changes from 3 commits
f536c53
61ad7cb
de55881
a4abd57
a97ff18
aa4dfd9
fb5516e
7c68e65
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to avoid changes to the badges here, as they're now managed upstream in jaraco/skeleton. If these changes are important, let's contribute them back to the skeleton. It's okay for a downstream project to have an extra badge, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Original view pytest-flake8 1.2.2:
![image](https://private-user-images.githubusercontent.com/13418739/381262578-2a1d9e25-7188-4d9c-9ec5-5798471b25f7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxODUxMjQsIm5iZiI6MTczOTE4NDgyNCwicGF0aCI6Ii8xMzQxODczOS8zODEyNjI1NzgtMmExZDllMjUtNzE4OC00ZDljLTllYzUtNTc5ODQ3MWIyNWY3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDEwNTM0NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQxZGEwZDRhMTIzY2E0YzNkOWY0ZDZjZjY0NWI1NTE3MzYwYmQyMmEzNzNjMWIzODNiODNjNDU1YTVlNmEyNWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.oiwNB7oUerOpshFa0zcB02_rL5RUqZRVX5lff6346p4)
Skeleton view master:
![image](https://private-user-images.githubusercontent.com/13418739/381265876-0a1bb99d-a12e-4ad0-853e-1dd759640c34.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxODUxMjQsIm5iZiI6MTczOTE4NDgyNCwicGF0aCI6Ii8xMzQxODczOS8zODEyNjU4NzYtMGExYmI5OWQtYTEyZS00YWQwLTg1M2UtMWRkNzU5NjQwYzM0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDEwNTM0NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkzNDg2Njk2ZTU1ODMzZmM3YzU0YTdmNGM5MDc5MWFjYmFmZjQ0M2ZlNTgxMDM2YjExNmY5ZjQ1MGM5NmY1YjkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.SMJqYraC8M5-njioo45YajL3Pf_RUC6XA8SHkOapd18)
From current PR view:
![image](https://private-user-images.githubusercontent.com/13418739/381267317-55d74e8a-c097-4317-be5c-697545f715c8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxODUxMjQsIm5iZiI6MTczOTE4NDgyNCwicGF0aCI6Ii8xMzQxODczOS8zODEyNjczMTctNTVkNzRlOGEtYzA5Ny00MzE3LWJlNWMtNjk3NTQ1ZjcxNWM4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDEwNTM0NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBkOWRlZTBhNjIyNmVlMmJiN2JiN2I3Nzc0MWJmNjY3M2I2Y2RjNjFjNDRjOTc1MTkyMTQ4NTdlZDM2YTY0OWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.7aWolbeI6pn04g8BZNrPOzRrBOIL3vtH4S2UNscZvzg)
I have made some changes because, as you may notice in the documentation for version 1.2.2, there is a blue underline (very tiny) appearing between the labels tests and Ruff. This issue is likely related to the SVG extension at the end. In the skeleton, it may be unnoticeable due to other styles being present so to enhance clarity and coherence for this project, I have added a label and made adjustments to ensure that the pages appear more consistent and user-friendly.
I haven't looked into the skeleton project. I made the changes with varying degrees of familiarity with HTML and by reviewing the badges. I would prefer to focus on delivering a functioning version of pytest-flake8, and I would like others to benefit from this as well. I also apologize in advance for my English, as it is not at the highest level, and I often hear from people that it sounds very harsh, which is not my intention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very strange situation, and it looks good on PyPI...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaraco do you know what might be causing these differences? Is there a difference in generating HTML and CSS from .rst files? Are there any other mechanisms involved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaraco Do you have any suggestion in which direction we should go with this delivery?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recognize the skeleton project isn't something that's familiar to everyone. It's a way of dealing with the common concerns of project management across projects.
The skeleton project itself is never released, so whatever rendering you see of the badges in skeleton is ignorable. What really matters is what is rendered for the downstream projects (after substituting real project names for concrete projects).
I'm aware there are some issues with the rendering of badges in some situations. I'm unwilling to "fix" the rendering of the badges for individual projects. If the issue can be fixed for all projects, I'm good with that, but it needs to happen in the skeleton. My recommendation - just revert all changes to the badges and instead contribute the same changes upstream in the skeleton. The only thing I'm likely to accept in this project is an additional badge that appears after the "skeleton" badge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other words, let's just revert these changes and deal with them separately, so they aren't blocking the other changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.