Fix for issue #281 COG validation fails for sparse edge tiles #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PARSE and have sparse edge tiles in the overviews
vincentsarago
approved these changes
Feb 9, 2024
|
thanks a lot @mpadillaruiz 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#281
The rio-cogeo validator returns False even though it is a valid COG when there are sparse edge tiles in the file and/or overviews.
This was because the overviews are stored as sparse and the validator checks for the first tile offset of each overview (BLOCK_OFFSET_0_0 tag). Since there are sparse edge tiles, this value is zero, and it cannot verify that the overviews are in the right order, even though they are.
I changed the code to iterate over BLOCK_OFFSET_x_y based on the number of tile rows/columns for the main file and overviews. This makes sure that the data_offset variable gets populated if there is an offset after all the sparse tiles.
Added a new test that checks for a sparse image with sparse tiles on the edges. I also added the tif image for the test.