Skip to content

Commit

Permalink
Allow array unit test to pass with Microsoft ODBC driver
Browse files Browse the repository at this point in the history
It returns SQL_SUCCESS_WITH_INFO even when not using prepared statements
and errors happen and, more surprisingly, gives more errors from the
insert-and-update query.

Make the minimum changes to let the test pass with this driver without
changing its behaviour when using the FreeTDS driver.

Signed-off-by: Vadim Zeitlin <vz-soci@zeitlins.org>
  • Loading branch information
vadz authored and freddy77 committed Jan 23, 2025
1 parent 5341f12 commit 0450b12
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/odbc/unittests/array.c
Original file line number Diff line number Diff line change
Expand Up @@ -152,20 +152,20 @@ main(void)
/* all errors */
test_query = T("INSERT INTO #tmp1 (id, value) VALUES (?, ?)");
multiply = 257;
query_test(0, SQL_ERROR, "!!!!!!!!!!");
query_test(0, odbc_driver_is_freetds() ? SQL_ERROR : SQL_SUCCESS_WITH_INFO, "!!!!!!!!!!");
multiply = 257;
query_test(1, SQL_SUCCESS_WITH_INFO, "!!!!!!!!!!");

test_query = T("INSERT INTO #tmp1 (id, value) VALUES (?, ?)");
query_test(0, SQL_ERROR, "VV!!!!!!!!");
query_test(0, odbc_driver_is_freetds() ? SQL_ERROR : SQL_SUCCESS_WITH_INFO, "VV!!!!!!!!");
query_test(1, SQL_SUCCESS_WITH_INFO, "VV!!!!!!!!");

test_query = T("INSERT INTO #tmp1 (id, value) VALUES (900-?, ?)");
query_test(0, SQL_SUCCESS_WITH_INFO, "!!!!!!!VVV");
query_test(1, SQL_SUCCESS_WITH_INFO, "!!!!!!!VVV");

test_query = T("INSERT INTO #tmp1 (id) VALUES (?) UPDATE #tmp1 SET value = ?");
query_test(0, SQL_SUCCESS_WITH_INFO, "VVVV!V!V!V");
query_test(0, SQL_SUCCESS_WITH_INFO, odbc_driver_is_freetds() ? "VVVV!V!V!V" : "VV!!!!!!!!");
query_test(1, SQL_SUCCESS_WITH_INFO, "VV!!!!!!!!");

#ifdef ENABLE_DEVELOPING
Expand Down

0 comments on commit 0450b12

Please sign in to comment.