Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch images based on theme #78

Merged
merged 27 commits into from
Jul 20, 2020
Merged

Switch images based on theme #78

merged 27 commits into from
Jul 20, 2020

Conversation

Blind4Basics
Copy link
Contributor

@Blind4Basics Blind4Basics commented Jul 20, 2020

Testing for #71 (waiting for the rendered preview version to see if that works... it doesn't x) )

@Blind4Basics
Copy link
Contributor Author

'doesn't seem to work... :/

image

What did I mess?

@Blind4Basics
Copy link
Contributor Author

...tried adding the ./img folder at root level: doesn't work either... (desperate fail, desperate attempt... XD )

(note: some files to remove from that branch, when it's done)

@Blind4Basics Blind4Basics requested a review from kazk July 20, 2020 13:39
Copy link
Member

@kazk kazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently we can't use <img> tag for relative path. We might need to do:

<div class="block dark:hidden">

![alt](./light.png)

</div>
<div class="hidden dark:block">

![alt](./dark.png)

</div>

for now. I might add Markdown extension to add custom classes.

Can you also use lowercase extension .png?

@Blind4Basics
Copy link
Contributor Author

Blind4Basics commented Jul 20, 2020

looks like it's ok, now :)
All changed and I removed all the pending files/folders.

@kazk kazk changed the title Test dark light pictures Switch images based on theme Jul 20, 2020
@kazk kazk merged commit 44b11d5 into master Jul 20, 2020
@kazk kazk deleted the test_dark_light_pictures branch July 20, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants