Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glossary: new update #123

Merged
merged 14 commits into from
Aug 17, 2020
Merged

glossary: new update #123

merged 14 commits into from
Aug 17, 2020

Conversation

Blind4Basics
Copy link
Contributor

No description provided.

@Blind4Basics Blind4Basics marked this pull request as draft August 9, 2020 10:16
data/glossary.yml Outdated Show resolved Hide resolved
data/glossary.yml Show resolved Hide resolved
data/glossary.yml Outdated Show resolved Hide resolved
data/glossary.yml Outdated Show resolved Hide resolved
data/glossary.yml Outdated Show resolved Hide resolved
data/glossary.yml Outdated Show resolved Hide resolved
data/glossary.yml Outdated Show resolved Hide resolved
data/glossary.yml Outdated Show resolved Hide resolved
data/glossary.yml Outdated Show resolved Hide resolved
data/glossary.yml Outdated Show resolved Hide resolved
data/glossary.yml Outdated Show resolved Hide resolved
@Blind4Basics Blind4Basics marked this pull request as ready for review August 11, 2020 07:35
@Blind4Basics
Copy link
Contributor Author

Blind4Basics commented Aug 11, 2020

OK, ready for review.

I tried some things along the way (aside from those see/link stuffs), and it looks like the css would benefit from some changes:

  • currently:

    • when using a new paragraph in a definition, the space between the two lines/paragraphs is rather 'big" (see dan for example)
    • this spacing is exactly (edit: actually almost exactly) the same between 2 § of the same term than the one btetween the title of a term and the text of the previous one
  • suggestion:

    • reduce the space betwee § (should just be a line feed, actually, no additional space)
    • enforce "several line feeds" inbetween different terms

here is the issue with the list of new terms added/needing review (a lot of old ones still need a check): #23

@Blind4Basics Blind4Basics requested review from kazk and hobovsky August 11, 2020 07:41
@Blind4Basics Blind4Basics changed the title try links syntax to other entries glossary: new update Aug 11, 2020
@kazk
Copy link
Member

kazk commented Aug 11, 2020

Spacing between paragraphs are from the plugin I trust and wouldn't want to change it. I'll increase the spacing between terms.

@Blind4Basics
Copy link
Contributor Author

should we approve this one or you need to stalk through the definitions yet?

data/glossary.yml Outdated Show resolved Hide resolved
data/glossary.yml Outdated Show resolved Hide resolved
data/glossary.yml Outdated Show resolved Hide resolved
data/glossary.yml Outdated Show resolved Hide resolved
@Blind4Basics Blind4Basics merged commit 438d1b6 into master Aug 17, 2020
@Blind4Basics Blind4Basics deleted the update-glossary branch August 17, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants