Add new lesson to the README table #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illuhad
reviewed
Jan 13, 2025
README.md
Outdated
| | 20 | Matrix Transpose | [slides][lesson-20-slides] | [exercise][lesson-20-exercise] | [source][lesson-20-source] | [solution][lesson-20-solution] | | ||
| | 21 | More SYCL Features | [slides][lesson-21-slides] | [exercise][lesson-21-exercise] | [source][lesson-21-source] | [solution][lesson-21-solution] | | ||
| | 22 | Functors | [slides][lesson-22-slides] | [exercise][lesson-22-exercise] | [source][lesson-22-source] | [solution][lesson-22-solution] | | ||
| | 23 | OneMath GEMM | [slides][lesson-23-slides] | [execise][lesson-23-exercise] | [source][lesson-23-source] | [solution][lesson-23-solution] | |
There was a problem hiding this comment.
AFAIK, oneMath is broken with AdaptiveCpp, and even if the current issues are fixed, oneMath has never supported all backends with AdaptiveCpp (e.g. Intel GPU was never supported).
AdaptiveCpp does in general not support UXL libraries and vice versa.
There was a problem hiding this comment.
I've moved the oneMath sample to a separate table. Personally I'd still like to see oneMath start incorporating more changes to be a bit more friendly to other implementations, but we've not embarked on that yet (in a way that doesn't require anything special from AdaptiveCpp).
Also remove the lines about where it works, we now expect all lessons to work on either dpcpp or AdaptiveCpp and will strive to make sure that's true generally.
DuncanMcBain
force-pushed
the
fix-table
branch
from
1d00839 to
df61040
Compare
DuncanMcBain
force-pushed
the
fix-table
branch
from
994d23a to
5937513
Compare
DuncanMcBain
force-pushed
the
fix-table
branch
from
5937513 to
f1bb7fb
Compare
rafbiels
requested changes
Jan 28, 2025
Co-authored-by: Rafal Bielski <rafal.bielski@codeplay.com>
rafbiels
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the lines about where it works, we now expect all lessons to work on either dpcpp or AdaptiveCpp and will strive to make sure that's true generally.