Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tool for debugging copies #224

Open
wants to merge 8 commits into
base: sycl-develop
Choose a base branch
from

Conversation

t4c1
Copy link
Collaborator

@t4c1 t4c1 commented Feb 20, 2025

Add a tool for understanding various copy operations that prints out layout of the copied data, which should be useful for debugging.

@t4c1 t4c1 changed the title Add a tool for reverse engineering copies Add a tool for debugging copies Feb 20, 2025
@mehdi-goli
Copy link
Collaborator

Thank @t4c1 . There is a folder called tools maybe you can put this there

@t4c1 t4c1 force-pushed the copy_reverse_engineer branch from 7fe0080 to 13abf3f Compare February 21, 2025 09:07
Copy link
Collaborator

@joeatodd joeatodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor issue.

Comment on lines 117 to 118
auto gridDim = syclcompat::dim3(SUBGROUP_SIZE);
auto blockDim = syclcompat::dim3(SUBGROUP_SIZE);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This launches 16x16 threads. Is that your intention?

Copy link
Collaborator Author

@t4c1 t4c1 Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think so (or I would have multiple printouts). I think this is the relevant dim3 constructor, right?

  constexpr dim3(unsigned int x = 1, unsigned int y = 1, unsigned int z = 1)
      : x(x), y(y), z(z) {}
      ```

Copy link
Collaborator

@aacostadiaz aacostadiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants