-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a tool for debugging copies #224
base: sycl-develop
Are you sure you want to change the base?
Conversation
Thank @t4c1 . There is a folder called tools maybe you can put this there |
…ss-fork into copy_reverse_engineer
7fe0080
to
13abf3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor issue.
auto gridDim = syclcompat::dim3(SUBGROUP_SIZE); | ||
auto blockDim = syclcompat::dim3(SUBGROUP_SIZE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This launches 16x16 threads. Is that your intention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think so (or I would have multiple printouts). I think this is the relevant dim3 constructor, right?
constexpr dim3(unsigned int x = 1, unsigned int y = 1, unsigned int z = 1)
: x(x), y(y), z(z) {}
```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Add a tool for understanding various copy operations that prints out layout of the copied data, which should be useful for debugging.