Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix codeigniter/coding-standard version to 1.7.* #1131

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 17, 2024

Description
coding-standard 1.8.0 enables rules for PHP 8.1.
So we cannot use it unless we drop PHP 7.4 support.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

1.8.0 enables rules for PHP 8.1.
So we cannot use it unless we drop PHP 7.4 support.
@kenjis kenjis merged commit b1f85d2 into codeigniter4:develop Jun 17, 2024
31 checks passed
@kenjis kenjis deleted the fix-ci-coding-standard-version branch June 17, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants