Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for every database handler #49

Merged
merged 16 commits into from
Dec 30, 2024

Conversation

michalsn
Copy link
Member

@michalsn michalsn commented Sep 19, 2024

Description
This PR adds tests for all database handlers.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn
Copy link
Member Author

Okay, seems like I will have to set up a local docker image to resolve this.

@michalsn michalsn requested a review from kenjis September 20, 2024 18:18
@coveralls
Copy link

coveralls commented Sep 20, 2024

Pull Request Test Coverage Report for Build 12515475471

Details

  • 25 of 25 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.1%) to 90.501%

Totals Coverage Status
Change from base Build 10938598555: 3.1%
Covered Lines: 524
Relevant Lines: 579

💛 - Coveralls

@michalsn michalsn mentioned this pull request Sep 23, 2024
5 tasks
@michalsn michalsn merged commit f37f8e5 into codeigniter4:develop Dec 30, 2024
19 checks passed
@michalsn
Copy link
Member Author

Thank you @paulbalandan!

@michalsn michalsn deleted the more-tests branch January 17, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants