Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: connection name for used handler #36

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

michalsn
Copy link
Member

@michalsn michalsn commented Jan 6, 2024

Description
This PR fixes the connection name we set in the queue_jobs_failed table. Now the name is properly set, depending on the used handler.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7434208947

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 87.433%

Totals Coverage Status
Change from base Build 7357997125: 0.07%
Covered Lines: 487
Relevant Lines: 557

💛 - Coveralls

@michalsn michalsn merged commit 1482353 into codeigniter4:develop Jan 9, 2024
13 checks passed
@michalsn
Copy link
Member Author

michalsn commented Jan 9, 2024

Thank you!

@michalsn michalsn deleted the connection-name branch September 19, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants