refactor: fix type inconsistency and more #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is based on @kenjis PR: #11. It fixes some more errors catched by phpstan and adds slightly better validation for command options.
Since these are valid calls, I had to suppress calls to methods:
QueueJobFailedModel::affectedRows()
andQueueJobFailedModel::truncate()
. I guess phpstan can't get what we do in the model.Checklist: