Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix type inconsistency and more #12

Merged
merged 9 commits into from
Dec 17, 2023

Conversation

michalsn
Copy link
Member

@michalsn michalsn commented Dec 17, 2023

Description
This PR is based on @kenjis PR: #11. It fixes some more errors catched by phpstan and adds slightly better validation for command options.

Since these are valid calls, I had to suppress calls to methods: QueueJobFailedModel::affectedRows() and QueueJobFailedModel::truncate(). I guess phpstan can't get what we do in the model.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn mentioned this pull request Dec 17, 2023
5 tasks
@michalsn michalsn merged commit 088523a into codeigniter4:develop Dec 17, 2023
11 checks passed
@michalsn michalsn deleted the type-fixes branch December 17, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants