From 26365413a53dcff15da78f8c0666a27ab8c10726 Mon Sep 17 00:00:00 2001 From: kenjis Date: Mon, 25 Mar 2024 09:30:28 +0900 Subject: [PATCH] docs: add @TODO --- system/Database/Postgre/Connection.php | 3 +++ tests/system/Database/ConfigTest.php | 3 +++ 2 files changed, 6 insertions(+) diff --git a/system/Database/Postgre/Connection.php b/system/Database/Postgre/Connection.php index d488c96ec1d4..baef703b7bb3 100644 --- a/system/Database/Postgre/Connection.php +++ b/system/Database/Postgre/Connection.php @@ -65,6 +65,9 @@ public function connect(bool $persistent = false) } // Convert DSN string + // @TODO This format is for PDO_PGSQL. + // https://www.php.net/manual/en/ref.pdo-pgsql.connection.php + // Should deprecate? if (mb_strpos($this->DSN, 'pgsql:') === 0) { $this->convertDSN(); } diff --git a/tests/system/Database/ConfigTest.php b/tests/system/Database/ConfigTest.php index e5fb383bc543..90724a82e383 100644 --- a/tests/system/Database/ConfigTest.php +++ b/tests/system/Database/ConfigTest.php @@ -198,6 +198,9 @@ public function testConnectionGroupWithDSNPostgreNative(): void */ public function testConvertDSN(string $input, string $expected): void { + // @TODO This format is for PDO_PGSQL. + // https://www.php.net/manual/en/ref.pdo-pgsql.connection.php + // Should deprecate? $this->dsnGroupPostgreNative['DSN'] = $input; $conn = Config::connect($this->dsnGroupPostgreNative, false); $this->assertInstanceOf(BaseConnection::class, $conn);