Merge pull request #8286 from kenjis/remove-Controller-loadHelpers

refactor: remove deprecated Controller::loadHelpers()
codeigniter4 · Dec 7, 2023 · 74b4ac5 · 74b4ac5
2 parents 1081b19 + 370becc
commit 74b4ac5
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 23 deletions.
diff --git a/phpstan-baseline.php b/phpstan-baseline.php
@@ -816,11 +816,6 @@
 	'count' => 4,
 	'path' => __DIR__ . '/system/Config/Services.php',
 ];
-$ignoreErrors[] = [
-	'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Controller.php',
-];
 $ignoreErrors[] = [
 	'message' => '#^Only booleans are allowed in a negated boolean, array given\\.$#',
 	'count' => 1,

diff --git a/system/Controller.php b/system/Controller.php
@@ -123,24 +123,6 @@ protected function cachePage(int $time)
         Services::responsecache()->setTtl($time);
     }
 
-    /**
-     * Handles "auto-loading" helper files.
-     *
-     * @deprecated Use `helper` function instead of using this method.
-     *
-     * @codeCoverageIgnore
-     *
-     * @return void
-     */
-    protected function loadHelpers()
-    {
-        if (empty($this->helpers)) {
-            return;
-        }
-
-        helper($this->helpers);
-    }
-
     /**
      * A shortcut to performing validation on Request data.
      *

diff --git a/user_guide_src/source/changelogs/v4.5.0.rst b/user_guide_src/source/changelogs/v4.5.0.rst
@@ -211,6 +211,7 @@ Others
 ------
 
 - **Config:** The deprecated ``CodeIgniter\Config\Config`` class has been removed.
+- **Controller:** The deprecated ``Controller::loadHelpers()`` method has been removed.
 
 Enhancements
 ************