Added makefile to rules engine #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we update CI to use Makefile to remove duplication? |
Yeah, that's a good idea. |
|
@jkwan2011 done |
jkwan2011
approved these changes
Oct 11, 2023
TIL: https://stackoverflow.com/a/12686411
|
axiomizer
reviewed
Oct 11, 2023
AdamFinkle
pushed a commit
to AdamFinkle/home-energy-analysis-tool
that referenced
this pull request
May 22, 2024
* added makefile * refactored github actions * refactored github actions * renamed make file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm finding it's somewhat difficult to share pre-commit hooks in a project. In lieu of that directly, this
makefileconsolidates everything into one step, so developers do not have to remember all the commands in CI.Run
make allfrom the rules-engine folder and it will check everything that CI checks.