Parse design temps from PDF to CSV #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkwan2011
reviewed
Oct 4, 2023
jkwan2011
reviewed
Oct 4, 2023
design_temp/clean.py
Outdated
| "Exhibit 1: Cooling and Heating Design Temperatures by State and County" | ||
| ) | ||
| content = content.split(table_title)[1] | ||
| pattern = r"[ ]+ENERGY STAR Certified Homes\nCounty-Level Design Temperature Reference Guide" |
There was a problem hiding this comment.
I'm assuming the space characters come from the text representation of the Energy Star graphic. Maybe we shouldn't assume it will always be spaces, but is .*?
There was a problem hiding this comment.
I'm a little nervous that .* will accidentally match some useful data that we need to process
jkwan2011
reviewed
Oct 4, 2023
jkwan2011
reviewed
Oct 4, 2023
jkwan2011
reviewed
Oct 4, 2023
jkwan2011
reviewed
Oct 4, 2023
AdamFinkle
pushed a commit
to AdamFinkle/home-energy-analysis-tool
that referenced
this pull request
May 22, 2024
Parse design temps from PDF to CSV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some code to parse the Energy Star PDF containing design temperatures.
See option 3 in Steve Breit's document Design Temperature for HEAT