Add pydantic and user input models #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axiomizer
reviewed
Sep 28, 2023
axiomizer
reviewed
Oct 11, 2023
|
As part of the outputs, we'll need information about each billing period: Whether the rules engine included that billing period, and the UA for that billing period |
Co-authored-by: Erika Nesse <erika-n@users.noreply.github.com> Co-authored-by: Alan Pinkert <alanisaac@users.noreply.github.com> Co-authored-by: Debajyoti Debnath <debajyotid2@users.noreply.github.com> Co-authored-by: harry <harryzhu626@users.noreply.github.com>
Refactored docstrings to 72 character maximum. Refactored if-else statement. Co-authored-by: Erika Nesse <erika-n@users.noreply.github.com> Co-authored-by: Nate <axiomizer@users.noreply.github.com> Co-authored-by: harry <harryzhu626@users.noreply.github.com> Co-authored-by: Debajyoti Debnath <debajyotid2@users.noreply.github.com> Co-authored-by: Jeff Korenstein <jkoren@users.noreply.github.com>
Co-authored-by: Erika Nesse <erika-n@users.noreply.github.com> Co-authored-by: harry <harryzhu626@users.noreply.github.com> Co-authored-by: Debajyoti Debnath <debajyotid2@users.noreply.github.com> Co-authored-by: Jonathan Kwan <jkwan2011@users.noreply.github.com> Co-authored-by: Nate <axiomizer@users.noreply.github.com>
Co-authored-by: harry <harryzhu626@users.noreply.github.com> Co-authored-by: Erika Nesse <erika-n@users.noreply.github.com> Co-authored-by: Debajyoti Debnath <debajyotid2@users.noreply.github.com> Co-authored-by: KKaempen <KKaempen@users.noreply.github.com> Co-authored-by: Alan Pinkert <alanisaac@users.noreply.github.com>
jkwan2011
force-pushed
the
add_pydantic
branch
from
75d26b4 to
a31f8de
Compare
…ata class Co-authored-by: Jonathan Kwan <jkwan2011@users.noreply.github.com> Co-authored-by: Debajyoti Debnath <debajyotid2@users.noreply.github.com> Co-authored-by: Erika Nesse <erika-n@users.noreply.github.com>
Co-authored-by: harry <harryzhu626@users.noreply.github.com>
jkwan2011
reviewed
Nov 28, 2023
| date=row["Date"], temperature=row[weather_station] # type: ignore[arg-type] | ||
| ) | ||
| result.append(item) | ||
| dates.append(row["Date"]) |
There was a problem hiding this comment.
Do we need to pass this to strptime?
jkwan2011
approved these changes
Nov 28, 2023
Co-authored-by: Debajyoti Debnath <debajyotid2@users.noreply.github.com> Co-authored-by: Jonathan Kwan <jkwan2011@users.noreply.github.com>
AdamFinkle
pushed a commit
to AdamFinkle/home-energy-analysis-tool
that referenced
this pull request
May 22, 2024
* adding pydantic dependency * Added user input models. Co-authored-by: Erika Nesse <erika-n@users.noreply.github.com> Co-authored-by: Alan Pinkert <alanisaac@users.noreply.github.com> Co-authored-by: Debajyoti Debnath <debajyotid2@users.noreply.github.com> Co-authored-by: harry <harryzhu626@users.noreply.github.com> * Added SummaryOutput class. Refactored docstrings to 72 character maximum. Refactored if-else statement. Co-authored-by: Erika Nesse <erika-n@users.noreply.github.com> Co-authored-by: Nate <axiomizer@users.noreply.github.com> Co-authored-by: harry <harryzhu626@users.noreply.github.com> Co-authored-by: Debajyoti Debnath <debajyotid2@users.noreply.github.com> Co-authored-by: Jeff Korenstein <jkoren@users.noreply.github.com> * black * Moved Pydantic models into split folder Co-authored-by: Erika Nesse <erika-n@users.noreply.github.com> Co-authored-by: harry <harryzhu626@users.noreply.github.com> Co-authored-by: Debajyoti Debnath <debajyotid2@users.noreply.github.com> Co-authored-by: Jonathan Kwan <jkwan2011@users.noreply.github.com> Co-authored-by: Nate <axiomizer@users.noreply.github.com> * updated pydantic models * Refactor Home class in engine.py. * changes from this session * cleaned up code from halloween! * added SummaryInput to home * Fixed black Co-authored-by: harry <harryzhu626@users.noreply.github.com> Co-authored-by: Erika Nesse <erika-n@users.noreply.github.com> Co-authored-by: Debajyoti Debnath <debajyotid2@users.noreply.github.com> Co-authored-by: KKaempen <KKaempen@users.noreply.github.com> Co-authored-by: Alan Pinkert <alanisaac@users.noreply.github.com> * fix mypy * added entry point functions, inclusion code conversion, and weather data class Co-authored-by: Jonathan Kwan <jkwan2011@users.noreply.github.com> Co-authored-by: Debajyoti Debnath <debajyotid2@users.noreply.github.com> Co-authored-by: Erika Nesse <erika-n@users.noreply.github.com> * updated tests based on new framework Co-authored-by: harry <harryzhu626@users.noreply.github.com> * fix lints * fixed datetime parsing Co-authored-by: Debajyoti Debnath <debajyotid2@users.noreply.github.com> Co-authored-by: Jonathan Kwan <jkwan2011@users.noreply.github.com> * mypy fix --------- Co-authored-by: Jonathan Kwan <jkwan2011@users.noreply.github.com> Co-authored-by: Erika Nesse <erika-n@users.noreply.github.com> Co-authored-by: Alan Pinkert <alanisaac@users.noreply.github.com> Co-authored-by: Debajyoti Debnath <debajyotid2@users.noreply.github.com> Co-authored-by: harry <harryzhu626@users.noreply.github.com> Co-authored-by: Nate <axiomizer@users.noreply.github.com> Co-authored-by: Jeff Korenstein <jkoren@users.noreply.github.com> Co-authored-by: KKaempen <KKaempen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a PR from our work this week, to see CI status and as a reminder for next week.