Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

162 CSV post action #229

Merged
merged 13 commits into from
Aug 14, 2024
Merged

162 CSV post action #229

merged 13 commits into from
Aug 14, 2024

Conversation

thadk
Copy link
Member

@thadk thadk commented Aug 7, 2024

  • Resolve Connect JavaScript forms to CSV parsing #162 by "roundtripping" all data required for form and interactivity
    • Parse bill (CSV or XML) for start and end date of bill (pyodide->JS)
    • Re-parse bill and submit to rules engine, receiving full output for table: (output: foo)
    • Take full output for table, as a trial, set override to true, and try to pass back through to rules engine again (output: foo2).
  • [ ]
  • Why is foo2.get('billing_records')._override` coming back out as false again? May be way of modifying Map in JS or something with the rules engine.
  • Rename foo and foo2
  • Figure out how to return results to page and table, maybe useAction?
  • Resolve type issue:
image

@thadk
Copy link
Member Author

thadk commented Aug 7, 2024

See also #123 about design temp and the rules engine implementation to incorporate into JS #228

thadk and others added 12 commits August 14, 2024 00:26
Co-authored-by: Leopardfoot <Leopardfoot@users.noreply.github.com>
Co-authored-by: plocket <plocket@users.noreply.github.com>
Co-authored-by: Camden Blatchly <camdenblatchly@users.noreply.github.com>
Co-authored-by: Jake McCambley <McCambley@users.noreply.github.com>
Co-authored-by: Camden Blatchly <camdenblatchly@users.noreply.github.com>
Co-authored-by: Charlie Kelly <charliekelly31415@gmail.com>
Co-authored-by: Steve Breit <stevebreit@users.noreply.github.com>
…ttps://github.com/epicweb-dev/web-forms/blob/b69e441f5577b91e7df116eba415d4714daacb9d/exercises/05.complex-structures/01.solution.nested/app/routes/users%2B/%24username_%2B/notes.%24noteId_.edit.tsx

Co-authored-by: plocket <plocket@users.noreply.github.com>
Co-authored-by: Leopardfoot <Leopardfoot@users.noreply.github.com>
Co-authored-by: Charlie Kelly <charliekelly31415@gmail.com>
Co-authored-by: plocket <plocket@users.noreply.github.com>
Co-authored-by: Charlie Kelly <charliekelly31415@gmail.com>
…weather

Co-authored-by: plocket <plocket@users.noreply.github.com>
Co-authored-by: Charlie Kelly <charliekelly31415@gmail.com>
Co-authored-by: tragicPanda10 <tragicPanda10@users.noreply.github.com>
…hema & pass .

designTemperature=12.

Co-authored-by: Charlie Kelly <charliekelly31415@gmail.com>
Co-authored-by: Devin Altobello <daltobello@users.noreply.github.com>
Co-authored-by: plocket <plocket@users.noreply.github.com>
…xecuteRoundtripAnalyticsFromFormJs to end.

Co-authored-by: Leopardfoot <Leopardfoot@users.noreply.github.com>
Co-authored-by: plocket <plocket@users.noreply.github.com>
Co-authored-by: Agustin V <vijoditz-agustin@users.noreply.github.com>
…e design temp, tabs->spaces

Co-authored-by: Devin Altobello <daltobello@users.noreply.github.com>
Co-authored-by: plocket <plocket@users.noreply.github.com>
Co-authored-by: Charlie Kelly <charliekelly31415@gmail.com>
Co-authored-by: Debajyoti Debnath <debajyotid2@users.noreply.github.com>
Co-authored-by: thatoldplatitude <thatoldplatitude@users.noreply.github.com>
@thadk thadk force-pushed the 162_csv_post_action branch from bb1ab36 to 7e72fc1 Compare August 14, 2024 01:17
@thadk
Copy link
Member Author

thadk commented Aug 14, 2024

Potential more elegant implementation:
06561cd#diff-f9a84c0372e3e8c1aa88ca4db0f9369911f88724f164561e3a96bd010959f331R186
image

@thatoldplatitude thatoldplatitude merged commit fd02144 into main Aug 14, 2024
8 checks passed
@thatoldplatitude
Copy link
Collaborator

lgtm

@plocket plocket deleted the 162_csv_post_action branch August 27, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect JavaScript forms to CSV parsing
3 participants