Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript misc #209

Merged
merged 4 commits into from
Jun 22, 2024
Merged

Fix typescript misc #209

merged 4 commits into from
Jun 22, 2024

Conversation

ethanstrominger
Copy link
Collaborator

@ethanstrominger ethanstrominger commented Jun 21, 2024

I fixed misc.tsx so that it does not error when you run tsc. I don't know why previous jobs were succeeding, but with one small change tsc works more consistently. This is the error:
app/utils/misc.tsx:275:23 - error TS7023: 'downloadFile' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.

275 export async function downloadFile(url: string, retries: number = 0) {
~~~~~~~~~~~~

@ethanstrominger ethanstrominger requested a review from thadk June 21, 2024 20:31
@thadk
Copy link
Member

thadk commented Jun 22, 2024

Hi Ethan, thanks for this. I note that this file is maintained upstream in Epic Stack at: https://github.com/epicweb-dev/epic-stack/blob/main/app/utils/misc.tsx#L276 and was recently heavily refactored since we last migrated Epic Stack, although this part was not modified.

We are due to migrate our Epic Stack to use the more conventional Vite instead of previous Remix Compiler (added about 5 months ago). I'm just a bit concerned I'll forget to retain this change when I hand merge the new release but otherwise this looks good to me.

Copy link
Member

@thadk thadk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see small comment about Epic Stack maintaining this file

@thadk thadk merged commit 93c6401 into main Jun 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants