Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor functional programming: change _calculate_avg_non_heating_usage to pass all variables #270

Open
5 tasks
ethanstrominger opened this issue Nov 12, 2024 · 0 comments

Comments

@ethanstrominger
Copy link
Collaborator

  • Change
    _calculate_avg_non_heating_usage () =>
    to
avg_non_heating_usage = _get_avg_non_heating_usage (      
    fuel_type,
    avg_summer_usage,
    dhw_input.estimated_water_heating_efficiency, 
    dhw_input.number_of_occupants,
    stand_by_losses, 
    heating_system_efficiency
)

Part 1 - parameters

  • Add parameters and pass parameters to _get_avg_non_heating_usage
  • Change self. for any of these variables to get rid of the self.
    Part 2 - return variable
  • Modify _get_avg_non_heating_usage to return a value
  • Include the value in the return home
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant