Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using uv for worker #896

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Try using uv for worker #896

wants to merge 4 commits into from

Conversation

Swatinem
Copy link
Contributor

I tried taking inspiration from https://hynek.me/articles/docker-uv/, but hit some snags along the way.

I would need to dig a bit deeper learning how the docker setup fully functions.

@Swatinem Swatinem self-assigned this Nov 15, 2024
@codecov-notifications
Copy link

codecov-notifications bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
- Coverage   98.04%   98.01%   -0.04%     
==========================================
  Files         444      444              
  Lines       35435    35543     +108     
==========================================
+ Hits        34744    34838      +94     
- Misses        691      705      +14     
Flag Coverage Δ
integration 41.99% <0.00%> (+0.03%) ⬆️
unit 90.87% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.07% <100.00%> (-0.07%) ⬇️
OutsideTasks 95.95% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
database/engine.py 91.48% <100.00%> (ø)
database/tests/unit/test_engine.py 100.00% <ø> (ø)
tasks/delete_owner.py 100.00% <100.00%> (ø)

... and 23 files with indirect coverage changes

@codecov-qa
Copy link

codecov-qa bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.01%. Comparing base (c20baed) to head (707d492).
Report is 6 commits behind head on main.

Current head 707d492 differs from pull request most recent head 94535f7

Please upload reports for the commit 94535f7 to get more accurate results.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
- Coverage   98.04%   98.01%   -0.04%     
==========================================
  Files         444      444              
  Lines       35435    35543     +108     
==========================================
+ Hits        34744    34838      +94     
- Misses        691      705      +14     
Flag Coverage Δ
integration 41.99% <0.00%> (+0.03%) ⬆️
unit 90.87% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.07% <100.00%> (-0.07%) ⬇️
OutsideTasks 95.95% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
database/engine.py 91.48% <100.00%> (ø)
database/tests/unit/test_engine.py 100.00% <ø> (ø)
tasks/delete_owner.py 100.00% <100.00%> (ø)

... and 23 files with indirect coverage changes

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.01%. Comparing base (c20baed) to head (707d492).
Report is 6 commits behind head on main.

Current head 707d492 differs from pull request most recent head 94535f7

Please upload reports for the commit 94535f7 to get more accurate results.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
- Coverage   98.04%   98.01%   -0.04%     
==========================================
  Files         444      444              
  Lines       35435    35543     +108     
==========================================
+ Hits        34744    34838      +94     
- Misses        691      705      +14     
Flag Coverage Δ
integration 41.99% <0.00%> (+0.03%) ⬆️
unit 90.87% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.07% <100.00%> (-0.07%) ⬇️
OutsideTasks 95.95% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
database/engine.py 91.48% <100.00%> (ø)
database/tests/unit/test_engine.py 100.00% <ø> (ø)
tasks/delete_owner.py 100.00% <100.00%> (ø)

... and 23 files with indirect coverage changes

Copy link

codecov-public-qa bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.01%. Comparing base (c20baed) to head (707d492).
Report is 6 commits behind head on main.

Current head 707d492 differs from pull request most recent head 94535f7

Please upload reports for the commit 94535f7 to get more accurate results.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
- Coverage   98.04%   98.01%   -0.04%     
==========================================
  Files         444      444              
  Lines       35435    35543     +108     
==========================================
+ Hits        34744    34838      +94     
- Misses        691      705      +14     
Flag Coverage Δ
integration 41.99% <0.00%> (+0.03%) ⬆️
unit 90.87% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.07% <100.00%> (-0.07%) ⬇️
OutsideTasks 95.95% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
database/engine.py 91.48% <100.00%> (ø)
database/tests/unit/test_engine.py 100.00% <ø> (ø)
tasks/delete_owner.py 100.00% <100.00%> (ø)

... and 23 files with indirect coverage changes

Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Instead of using `uv` virtualenv to build the image, we want to build the wheels
so that the docker app won't need to have dependency on build tools.
There's a few things that were fixed for the SQLAlchemy upgrade.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants