Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with value instead of keys for plan data dict #458

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

RulaKhaled
Copy link
Contributor

tier name maps to values.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@RulaKhaled RulaKhaled added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit abc6b36 Dec 20, 2024
6 checks passed
@RulaKhaled RulaKhaled deleted the quick-fix-for-enums branch December 20, 2024 16:42
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.98%. Comparing base (3616116) to head (94e5d68).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
- Coverage   90.58%   89.98%   -0.61%     
==========================================
  Files         401      324      -77     
  Lines       12508     9212    -3296     
  Branches     2103     1634     -469     
==========================================
- Hits        11330     8289    -3041     
+ Misses       1069      860     -209     
+ Partials      109       63      -46     
Flag Coverage Δ
shared-docker-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants