Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use project-scoped artifact names, return test job result as workflow output #45

Merged
merged 2 commits into from
Feb 22, 2025

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented Feb 21, 2025

two changes for https://github.com/codecov/umbrella/pull/12

first: umbrella now has a single workflow which runs worker, shared, and codecov-api workflows as subroutines. they, in turn, call these shared workflows which upload coverage and junit files with coveragefiles and junitfiles as their artifact names. worker and shared both try to use the same name and they fight. so, this change adds a prefix to the artifact name so there is no more conflict

second: each workflow now has an output variable that explicitly indicates whether tests passed. this is helpful for two reasons:

  • when using run-tests-split, the workflow output is the simplest way to check whether any of the matrixed jobs failed
  • we can make specifically the tests required and allow, like, the codecov upload jobs or whatever to fail if we want

@matt-codecov matt-codecov force-pushed the pr45 branch 7 times, most recently from 1fd882f to 219ff39 Compare February 21, 2025 22:18
@matt-codecov matt-codecov changed the title fix: use unique artifact names scoped to each project fix: use project-scoped artifact names, return test job result as workflow output Feb 21, 2025
@matt-codecov matt-codecov merged commit 225cf78 into main Feb 22, 2025
1 check passed
@matt-codecov matt-codecov deleted the pr45 branch February 22, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant