fix: use project-scoped artifact names, return test job result as workflow output #45
+18
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two changes for https://github.com/codecov/umbrella/pull/12
first: umbrella now has a single workflow which runs worker, shared, and codecov-api workflows as subroutines. they, in turn, call these shared workflows which upload coverage and junit files with
coveragefiles
andjunitfiles
as their artifact names. worker and shared both try to use the same name and they fight. so, this change adds a prefix to the artifact name so there is no more conflictsecond: each workflow now has an output variable that explicitly indicates whether tests passed. this is helpful for two reasons:
run-tests-split
, the workflow output is the simplest way to check whether any of the matrixed jobs failed