use codecov actions to upload instead of the cli #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr:
worker, shared, and API run their tests inside containers, but those containers all bindmount the working directory into the container. so when the tests write junit/coverage files, those files are visible outside of the container as well. this PR uploads those files with
upload-artifact
a separate job uses
download-artifact
+ a matrix to submit up to four uploads ({unit, integration} {coverage, junit}) to codecov in each of our four environmentsrun-tests-split.yml
presents an extra complication. the tests are themselves run in a matrix and produce several output files. i've done a few things to deal with that:unit.4.coverage.xml
,integration.2.junit.xml
pattern
argument fordownload-artifact
to download them all in one gofiles
arg in the action, which i think will work