Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Codecov upload issue debugging} - Ensuring the Codecov UI is able to react to data from a commit that is re-run #2684

Open
rohan-at-sentry opened this issue Oct 16, 2024 · 2 comments
Assignees
Labels
Area: Report Processing Issues with report processing Area: Report Upload Issues with pre-ingest report uploading epic this label is used to mark issues as epics in discovery The design, product, and specifications require refinement P0: must do priority 10
Milestone

Comments

@rohan-at-sentry
Copy link

rohan-at-sentry commented Oct 16, 2024

Problem

The Codecov UI is essentially static after the CI finishes for a commit - which is problematic in the following scenarios

  • when the user re-runs a commit on CI and therefore re-uploads coverage (typically done to eliminate flaky tests or fix a temporary issue with a coverage report

We want to ensure the Codecov UI updates data for the commit in this scenario.

Why is it important?

Not seeing consistency on what you see on the PR reflect what you see confuses people.

Path forward

  • ensure the coverage report errors on the commits tab are shown/not shown based on if the latest coverage report upload (new run, same commit) was successful or not

  • Update top level coverage statistics for the commit and PR with result from latest result Image

  • Set notify_error to true for all new customers (the default appears to be false). This allows any issues with uploads to surface on the PR comment as well --> serves as a warning signal to users that coverage reporting on the UI may be impacted.

@rohan-at-sentry rohan-at-sentry added Area: Report Processing Issues with report processing Area: Report Upload Issues with pre-ingest report uploading labels Oct 16, 2024
@rohan-at-sentry rohan-at-sentry added this to the Q4 '24 milestone Oct 16, 2024
@rohan-at-sentry rohan-at-sentry moved this to Consideration in Codecov's Roadmap Oct 16, 2024
@rohan-at-sentry rohan-at-sentry self-assigned this Oct 16, 2024
@rohan-at-sentry rohan-at-sentry added Dependency Dependency between teams in discovery The design, product, and specifications require refinement labels Oct 16, 2024
@rohan-at-sentry rohan-at-sentry changed the title Codecov upload issue debugging for Q4 {Codecov upload issue debugging} - Ensuring the Codecov UI is able to react to data from the latest upload Oct 21, 2024
@katia-sentry katia-sentry added the epic this label is used to mark issues as epics label Oct 22, 2024
@rohan-at-sentry rohan-at-sentry changed the title {Codecov upload issue debugging} - Ensuring the Codecov UI is able to react to data from the latest upload {Codecov upload issue debugging} - Ensuring the Codecov UI is able to react to data from a commit that is re-run Oct 24, 2024
@rohan-at-sentry rohan-at-sentry removed the Dependency Dependency between teams label Nov 5, 2024
@rohan-at-sentry
Copy link
Author

rohan-at-sentry commented Nov 5, 2024

Bring in platform if we need to store things to a db (for perf reasons)

@katia-sentry katia-sentry added the P0: must do priority 10 label Nov 21, 2024
@Adal3n3
Copy link

Adal3n3 commented Dec 20, 2024

Meeting with @suejung-sentry 12/20:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Report Processing Issues with report processing Area: Report Upload Issues with pre-ingest report uploading epic this label is used to mark issues as epics in discovery The design, product, and specifications require refinement P0: must do priority 10
Projects
Status: Solution Discovery
Development

No branches or pull requests

4 participants