This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Support Heroku CI #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
+ Coverage 96.35% 96.42% +0.07%
==========================================
Files 1 1
Lines 247 252 +5
==========================================
+ Hits 238 243 +5
Misses 9 9
Continue to review full report at Codecov.
|
|
Failing tests is due to #29. |
|
In addition, Heroku CI has a |
|
Any ETA for this one? |
|
Any news about this PR? |
|
@meganemura Any news about this? |
|
@stevepeak Would you please review this? |
|
In addition, this PR works well with my projects. |
|
@stevepeak ping |
meganemura
force-pushed
the
heroku-ci
branch
2 times, most recently
from
057e3ed to
8fe0fb1
Compare
|
@hootener Would you please review this? |
hootener
approved these changes
Oct 8, 2018
|
Merged and deployed to rubygems 👍 |
|
Thanks 😃 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we may be able to support Heroku CI.
refs:
https://docs.codecov.io/reference#upload
codeclimate/test-reporter#305
We can also set 'CODECOV_SLUG' via app.json.
related: #21