-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no comment on PRs when using v5 and app is not installed #1759
Comments
Here's another repo with the same issue: |
Ok, @HarelM I finally got a good answer for this. The App is NOT required, however, it is strongly recommended. Why is that? Well, the issue comes down to As a result, not having the app does not guarantee that you will get a comment or status checks. As for why did this work on v4? The v4 and v5 release are mutually exclusive from this problem. We have done some things on our side to help curtail the number of GitHub calls we make, but it is still unlikely to get a comment from Codecov when the app is not set up. |
Thanks for looking into this! |
@HarelM ok, here are some cases
Let me know if this helps! |
I'm trying to avoid the need to add a codecov.yml file to every repo I add codecov to (again, a lot of repos...). |
Thanks for the hint, for the IsraelHikingMap organization I test it, and it seems to do the job. |
See the title - the coverage comment does not appear if the app is not installed.
This is in continue to:
The following PR was created after disabling the codecov app, and as can be seen no coverage report comment is generated:
@thomasrockhu-codecov let me know if you need more details in order to address this.
The text was updated successfully, but these errors were encountered: