Skip to content

[PythonLab] Updates drag and drop focus states #65518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025

Conversation

hannahbergam
Copy link
Contributor

@hannahbergam hannahbergam commented Apr 26, 2025

Warning!!

The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2025. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.

This is a PR to unify focus states for the drag and drop elements. It is a followup to #65495

I am not updating the overflow properties during this update: I am just unifying the colors. In the future we could move to a box-shadow approach so we didn't have to worry about the focus appearing above the surrounding components. For now, that is outside of the scope of this work.

Before:

Screenshot 2025-04-25 at 7 37 28 PM Screenshot 2025-04-25 at 7 37 22 PM

After:

Screenshot 2025-04-25 at 7 36 53 PM Screenshot 2025-04-25 at 7 37 00 PM

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@hannahbergam hannahbergam requested a review from a team April 26, 2025 02:40
@hannahbergam hannahbergam merged commit c982c0a into staging Apr 28, 2025
6 checks passed
@hannahbergam hannahbergam deleted the hbergam/more-focus-state-colors branch April 28, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants