[WIP] 12-SearchApi

[sukeshni]

No description provided.

[sukeshni]

@shunjikonishi I think we will have to change the getter methods for Repository as well as User. I am not sure, please advice.
#43 (comment)

[shunjikonishi]

@sukeshni
Please paste search response on Gist

[sukeshni]

@shunjikonishi Gist created at https://gist.github.com/sukeshni/0ccf97bde002ab552dcf

[shunjikonishi]

See this.

https://github.com/code-check/github-api-scala/wiki/How-to-define-model

Maybe you can use trait.

[sukeshni]

@shunjikonishi Thanks for the wiki-link
@fanwashere Please review.

[fanwashere]

Maybe the other fields (path, sha, url, git_url, html_url) will be useful too.

[fanwashere]

@sukeshni fix me. I'm not sure if the query string implementation has to be changed, your implementation works; its just a matter of simplifying things. Also from Koni's comment:

$ git checkout master
$ git pull origin master
$ git checkout 3-issueAPI
$ git rebase master
(Maybe conflict happen, so you have to fix them with your editor.)
$ git rebase --continue
$ git push -f origin 3-issueAPI

To update to the latest changes.

[sukeshni]

@fanwashere Will update it with Master.
For Query String
Please see searchOpSpec, query string implementation/conversion in done.
Query will be checked on the client side and if something it wrong will be handled.
For ex.
User input query for searchRepositories will look like
q = "tetris language:assembly"
Here word "tetris" is searched in repositories having language set as "assembly".

[fanwashere]

@sukeshni That is fine then. However, I think you should add in the other fields in searchCodeItems.

[sukeshni]

@fanwashere I don't get the use of asserting (path, sha, url, git_url, html_url) for searchCodeItems. Please advice. Probably I should check for name, in SearchCode i am searching for language:js so i can check for filename with extension .js

[fanwashere]

@sukeshni Sorry for not being clear. Currently in searchCodeItems there are two methods:

def name: String = get("name")
lazy val Repo = new Repository(value \ "repository")

I usually check for the contents of the response JSON object by writing showResponse(result) into the tests. When I did that, I found that it also gives you those other fields (path, sha, url, git_url, html_url). But without a method like:

def path: String = get("path")

We cannot access those fields. Some fields are redundant but I feel that these fields may be useful.

[ashawley]

This PR can be closed in favor of #70, IMHO