Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search API #12

Open
13 tasks
shunjikonishi opened this issue May 5, 2015 · 5 comments
Open
13 tasks

Search API #12

shunjikonishi opened this issue May 5, 2015 · 5 comments

Comments

@shunjikonishi
Copy link
Contributor

models

  • SearchInput
  • SearchRepositoryResult(if necessary)
  • SearchCodeResult(if necessary)
  • SearchIssueResult(if necessary)
  • SearchUserResult(if necessary)

operations

  • searchRepositories(input: SearchInput)
  • searchCode(input: SearchInput)
  • searchIssues(input: SearchInput)
  • searchUsers(input: SearchInput)

test

  • searchRepositories(input: SearchInput)
  • searchCode(input: SearchInput)
  • searchIssues(input: SearchInput)
  • searchUsers(input: SearchInput)
@shunjikonishi shunjikonishi added this to the Sprint3 milestone May 5, 2015
@takayukioda takayukioda modified the milestone: Sprint3 Mar 22, 2016
@ashawley
Copy link
Contributor

I am working on cleaning up #36. I noticed the GitHub API has a commit search now. Did this capability exist 2 years ago when you were working on it? I'm wondering if it's worth implementing. Is it worth implementing?

@shunjikonishi
Copy link
Contributor Author

@ashawley
We are using this library in our own production web service.
Now this API has enough features for our product.
Just now, we don't need any more features for our product.

Also, we are using this API in our internal helper tool GitHub-Hook.

This tool is very helpful for us. And if I have time, I want to add more features to this tool.
To improve that tool, I have to add some more features to this API. But I don't have enough time.

This is current status of this API.

About #36, I don't remember well. Probably it is better to discard once.

@ashawley
Copy link
Contributor

Are you using the Search API in your production web service? I assume you are not. I think you mean you are using other parts of this library in your production web service.

@shunjikonishi
Copy link
Contributor Author

We don't use search API now.

@ashawley
Copy link
Contributor

ashawley commented Jan 20, 2017

Ok. Cool.

Thanks for mentioning your Github-Hook project. I will look at it.

I really appreciate this library. It is a good library.

The Commit Search that I asked about before is new. It is only available as a preview. More information here at GitHub blog post https://developer.github.com/changes/2017-01-05-commit-search-api/ We sure don't need to implement it since it is so new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants