Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed search bar transparent and search button #2144

Merged
merged 1 commit into from
Apr 2, 2024
Merged

fixed search bar transparent and search button #2144

merged 1 commit into from
Apr 2, 2024

Conversation

evnxprk
Copy link
Contributor

@evnxprk evnxprk commented Apr 1, 2024

Please let me know if there are changes to be made to this very code. Thank you.

@ImprovedTube
Copy link
Member

welcome & thanks! @evnxprk
i'm not a user of the feature yet! (are you?)
will try this. and try joaolscosta's work, to see how to call/combine it #2132 (comment)

@ImprovedTube ImprovedTube merged commit 93970bc into code-charity:master Apr 2, 2024
@ImprovedTube
Copy link
Member

"This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository."
not sure how this happened.


code doesn't look final either

@evnxprk
Copy link
Contributor Author

evnxprk commented Apr 2, 2024

I'm not sure why it says that but I can try to help merge it to your code, if possible. Could you elaborate more on what you mean by it doesn't look final?

ImprovedTube added a commit that referenced this pull request Apr 3, 2024
@ImprovedTube
Copy link
Member

hi! the first statement looks almost fine (hmtl)
hmtl[it-header-transparent=true] #search-button {opacity: 1 !important;}


the 2nd is attempting to change something for everyone, who doesnt have our transparent feature enabled
#search-button { background-color: rgba(255, 255, 255, 0.5); }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants