Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup player button gone #860

Open
iPherian opened this issue Apr 3, 2021 · 6 comments
Open

Popup player button gone #860

iPherian opened this issue Apr 3, 2021 · 6 comments
Labels
Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@iPherian
Copy link

iPherian commented Apr 3, 2021

Bug Report:

BUG:
Popup player button below video is missing

HOW:
Load any video

EXPECTED (/preferred) behavior:
button present

Context:
Problem also occurs with the master.zip in the bug report template ( same error msg too )
Browser console displays error message:

Uncaught TypeError: ImprovedTube.improvedtubeYoutubeSidebarButton is not a function
    at <anonymous>:2515:22

Setup:

⚬ Browser:
Chrome 89.0.4389.114
(up to date as of this issue posting)

⚬ ImprovedTube Version:
3.225

⚬ Settings:
0c322457-7209-46bf-bdb6-a8bbc4326487.zip

⚬ OS:
Windows 10 Pro 1909 build 18363.1316

⚬ Device:
Desktop

@iPherian iPherian added the help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) label Apr 3, 2021
@ImprovedTube
Copy link
Member

ImprovedTube commented Apr 4, 2021

hi! @iPherian are you a new user?
until now alll our player buttons appear next to youtube's play/pause (in the order in that you enabled them.)

the other button position is new and to decide about still: #1445
(i.e. how will to call them in the popup menu? will it be good for new users enabled by default?

@GKid94
Copy link

GKid94 commented Apr 4, 2021

I have the same issue with the player buttons missing when enabled

Brave browser 1.22.71 Chromium: 89.0.4389.114 (Official Build) (64-bit)
Improved YouTube version 3.225
Windows 10 Pro Version 20H2 19042.867

@iPherian
Copy link
Author

iPherian commented Apr 4, 2021

hi! @iPherian are you a new user?
until now alll our player buttons appear next to youtube's play/pause (in the order in that you enabled them.)

other buttons positions are new and to decide about still: #1445
(i.e. how will to call them in the popup menu? are they be good for new years enabled by default?

Oh, I see it now next to the play button. My bad. Previously I saw it underneath like in #1445 . I'm good now.

Willing to close, will let @GKid94 say if he still has an issue.

@GKid94
Copy link

GKid94 commented Apr 4, 2021

It seems to be fixed now

@ImprovedTube
Copy link
Member

ImprovedTube commented Apr 4, 2021

@iPherian nice to meet you! Your perspective was valid! since the additional position was (accidentally) active for some hours coinciding with the date of the ghacks/lifehacker articles. be avaiable nicely soon & drag and drop of buttons maybe?

will it be good for new users enabled by default?

= would you like to immediately have something to try out? (and maybe disable it, only with the extension popup)

@iPherian
Copy link
Author

iPherian commented Apr 4, 2021

Now that you mention it, I think I prefer the popout player I saw before.

  • It seemed to be able to play videos that couldn't be embedded, which was amazing. (indeed the reason I chose the extension in the first place)
  • The window took up less screen space (no address bar), when I use the popout player i'm usually trying to minimize screen usage so I can do other things too.

@iPherian nice to meet you! Your perspective was valid! since the additional position was (accidentally) active for some hours coinciding with the date of the ghacks/lifehacker articles. be avaiable nicely soon & drag and drop of buttons maybe?

Thanks!

= would you like to immediately have something to try out? (and maybe disable it, only with the extension popup)

I'd like that (popout button enabled by default). Otherwise as a new user (first install two days ago) I found it hard to know what the extension could do.

And/or if you mean running some sort of beta which is like I saw before, I wouldn't mind that. I thought it was pretty good.

Great extension btw!

@ImprovedTube ImprovedTube added x and removed help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) labels Apr 12, 2021
@code-charity code-charity deleted a comment from GKid94 Apr 12, 2021
@ghost ghost removed the _ label Jul 20, 2021
@ImprovedTube ImprovedTube added the Feature request Wish or idea label Dec 27, 2021
@ImprovedTube ImprovedTube added up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* labels Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

3 participants