Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: manual compactions that are internally cancelled should be retried #4298

Open
sumeerbhola opened this issue Jan 28, 2025 · 0 comments
Open

Comments

@sumeerbhola
Copy link
Collaborator

sumeerbhola commented Jan 28, 2025

We expose any error in a manual compaction to the client that requested the manual compaction. This was appropriate when an error may have represented something serious and non transient, which is how we had originally implemented compactions.

However, we now have internal cancellation

cancel atomic.Bool
which can happen due to an ingest (or flushable ingest) that excises or splits files involved in the compaction. An error due to an internal cancellation should be retried.

Jira issue: PEBBLE-335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants