Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv: entireSpanExcludedFromBackupRLocked returning false #131993

Open
dt opened this issue Oct 4, 2024 · 1 comment
Open

kv: entireSpanExcludedFromBackupRLocked returning false #131993

dt opened this issue Oct 4, 2024 · 1 comment
Labels
24.2 branch-master Failures and bugs on the master branch. branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-kv KV Team

Comments

@dt
Copy link
Member

dt commented Oct 4, 2024

We've observed some of our clusters failing to backup citing a gc threshold in the leases table of a tenant. This is interesting since this table has a config that says it is excluded from backup, so typically a gc error to a range for it would be decorated with a bool telling the backup processor that it can ignore the error since it didn't need data from that range anyway. However we're seeing this error bubble up which means it does not have this boolean on it. This seems like it could be because some tables, such as the MR system.leases table, have many span configs for the same table that are applying within the same range, but the entireSpanExcludedFromBackupRLocked check will report false right now if the config is not the same for the whole span (even if every config has the bit). We do see a stream of the warnings logged in this case in the logs.

More context in https://cockroachlabs.slack.com/archives/C0KB9Q03D/p1728074952547289.

Jira issue: CRDB-42779

@dt dt added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-kv KV Team labels Oct 4, 2024
Copy link

blathers-crl bot commented Oct 4, 2024

Hi @dt, please add branch-* labels to identify which branch(es) this C-bug affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@dt dt added branch-master Failures and bugs on the master branch. 24.2 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
24.2 branch-master Failures and bugs on the master branch. branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-kv KV Team
Projects
None yet
Development

No branches or pull requests

1 participant