eliminate deadlocks in Subscribe and AddListener #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code provides two mechanisms for clients to receive events from
a circuit breaker. Both contained logic which could potentially lead to
deadlocks. The logic assumed that clients prefer to receive more recent
events in the case where their channel is full and thus attempts to pull
events off the front of the client channel in the case where sends would block.
This however can lead to deadlocking when another goroutine is trying to send
an event on the channel (which can totally happen). This commit fixes the
possible deadlocks, adds testing, and clarifies in the comments that the event
mechanisms are best effort. This course of action was taken as opposed to
removing the functionality so as to not break existing external clients who may
be relying on it.
Addresses #47 from rubyist/circuitbreaker.
This change is