Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use released version of Level #143

Open
jayvdb opened this issue Aug 1, 2018 · 2 comments
Open

Use released version of Level #143

jayvdb opened this issue Aug 1, 2018 · 2 comments
Labels
area/dependencies type/feature

Comments

@jayvdb
Copy link
Member

jayvdb commented Aug 1, 2018

Currently depending on "level-js": "philschatz/level.js#master" , which has one extra commit from a branch 108 commits behind master of https://github.com/Level/level-js

The latest released version of level-js is quite different, and likely includes the needed configurability which that extra commit provided.
@jayvdb
Copy link
Member Author

jayvdb commented Aug 1, 2018

Also the related "levelidb": "^0.2.6" causes a dependency on git repo https://github.com/Raynos/IDBWrapper.git@7958b742d7d41432bbf1f897ee1507edc6bff64e

@li-boxuan
Copy link
Member

Seems the needed configurability is not provided by release version of level-js.

But levelidb can be safely removed I guess, I don't see any dependency on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/dependencies type/feature
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jayvdb @li-boxuan