Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to display welcome message with regex #659

Open
RohanVB opened this issue May 21, 2019 · 4 comments
Open

Add feature to display welcome message with regex #659

RohanVB opened this issue May 21, 2019 · 4 comments

Comments

@RohanVB
Copy link
Member

RohanVB commented May 21, 2019

For any message such as hello world!, as long as it contains hello world should prompt the welcome message to be displayed

@sladyn98
Copy link

@RohanVB I'm not entirely sure why we would need this :P because we have mentioned in our docs that the message to be posted for help is the wonderful hello world :)

@RohanVB
Copy link
Member Author

RohanVB commented May 23, 2019

Just came across a few users using variations of the expression and thought it'd be useful. People usually explain that they need to type exactly hello world to trigger corobo (including the quotes). Hence the expression with quotes could be removed and everything else containing hello world could be included.

@Vamshi99
Copy link
Member

Yes, Hello world! should be allowed. More than one ! also should be allowed.

@sladyn98
Copy link

@RohanVB Oh understood 👍
@Vamshi99 Just let me get a few of my PR's merged and will get to discussing this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants