Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dep munkres3 with munkres #2883

Merged
merged 1 commit into from
Jul 22, 2019
Merged

Conversation

KVGarg
Copy link
Contributor

@KVGarg KVGarg commented Mar 4, 2019

The official munkres now supports Python3, so
we don't need to use munkres3.

Closes #2871

@KVGarg
Copy link
Contributor Author

KVGarg commented Mar 4, 2019

@jayvdb Please review the changes !

@KVGarg KVGarg force-pushed the replace-dep-munkres3 branch from 70ab701 to 886ca00 Compare July 21, 2019 16:32
Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message doesnt refer to the issue

@KVGarg
Copy link
Contributor Author

KVGarg commented Jul 22, 2019

Commit message doesnt refer to the issue

I’m so sorry for this! Will edit the commit message and push it again 😇

The official [munkres](https://github.com/bmc/munkres)
now supports Python3, so we don't need to use
[munkres3](https://github.com/datapublica/munkres).

Closes coala#2871
@KVGarg KVGarg force-pushed the replace-dep-munkres3 branch from 886ca00 to afb068b Compare July 22, 2019 04:16
@jayvdb jayvdb merged commit afb068b into coala:master Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Replace dep munkres3 with munkres
3 participants