cEP-0030: Next Generation Action System #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshatkarani
force-pushed
the
cEP-0030
branch
2 times, most recently
from
d39d989 to
1095d09
Compare
Ping @Makman2 |
|
I would also expect a few more details. Especially basic implementation approach and how to integrate it with current coala's internas. |
akshatkarani
force-pushed
the
cEP-0030
branch
4 times, most recently
from
cb44845 to
1b18c5e
Compare
Makman2
reviewed
Jun 25, 2019
cEP-0030.md
Outdated
| ```python | ||
|
|
||
| ACTIONS = [DoNothingAction(), | ||
| ApplyPatchAction(), |
There was a problem hiding this comment.
Isn't this meaningless without supplying a specific patch?
There was a problem hiding this comment.
I am not changing the current actions and adding a init method to it. Instead result.actions will only have actions that bears have defined. See the PR coala/coala#6029 for the implementation of this.
There was a problem hiding this comment.
Anyways a test was failing because of this change and I removed it from PR. So I will update here as well.
|
@Makman2 Updated cEP. You can check out the PRs here coala/coala#6029 coala/coala-bears#2927 |
akshatkarani
force-pushed
the
cEP-0030
branch
2 times, most recently
from
06b2afe to
0e76d9e
Compare
akshatkarani
force-pushed
the
cEP-0030
branch
2 times, most recently
from
a914ce9 to
42015fc
Compare
abhishalya
requested changes
Jul 18, 2019
abhishalya
previously approved these changes
Aug 11, 2019
abhishalya
approved these changes
Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #181