Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert factor columns to character before checking max character length #127

Merged
merged 3 commits into from
May 27, 2024
Merged

Convert factor columns to character before checking max character length #127

merged 3 commits into from
May 27, 2024

Conversation

matt-dray
Copy link
Collaborator

@matt-dray matt-dray commented May 27, 2024 •
edited
Loading

Close #110, close #113.

  • Coerce factor columns to character before using nchar() to decide whether columns should be widened.
  • Bump version number in DESCRIPTION and NEWS.
  • Use tidy DESCRIPTION.

@matt-dray matt-dray merged commit 2e389ca into main May 27, 2024
7 checks passed
@matt-dray matt-dray deleted the 110-nchar-bug branch May 27, 2024 14:02
@matt-dray matt-dray mentioned this pull request May 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert factors to character in tables components? generate_workbook produces error
1 participant
@matt-dray