Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing error detection in CI #80

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Fixing error detection in CI #80

merged 3 commits into from
Feb 19, 2024

Conversation

louisjdmartin
Copy link
Member

Proposed changes

Fix CI error detection

Types of changes

What types of changes does your code introduce to this project?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Issues closed by changes

List here all issues closed by your changes. Use a list of items like - [x] Close #0

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I agree with the CODE OF CONDUCT
  • Lint and unit tests pass locally with my changes
  • Codacy validates the quality of the modifications
  • GitHub Actions CI workflow passes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@louisjdmartin louisjdmartin added this to the 3.2.1 milestone Feb 19, 2024
@louisjdmartin louisjdmartin changed the title Fixing error detection in CI - THIS CI MUST FAIL Fixing error detection in CI Feb 19, 2024
@dev31520 dev31520 merged commit d5e3593 into develop Feb 19, 2024
4 checks passed
@dev31520 dev31520 deleted the fix-test-CI branch February 19, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fails but CI is ok
2 participants