Change DQM modules to use stage-2 L1T #37033

tvami · 2022-02-22T16:42:19Z

PR description:

Based on #37016 (comment)
this PR moves different DQM modules to use stage-2 L1T

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

Resolves #37016

cmsbuild · 2022-02-22T16:53:02Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37033/28462

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQMOffline/Trigger/python/BPHMonitor_cfi.py modified in PR(s): Drop type specs for DQMOffline/Trigger #36783
- File DQMOffline/Trigger/python/JetMonitor_cfi.py modified in PR(s): Drop type specs for DQMOffline/Trigger #36783
- File DQMOffline/Trigger/python/METMonitor_cfi.py modified in PR(s): Drop type specs for DQMOffline/Trigger #36783
- File DQMOffline/Trigger/python/MuonMonitor_cfi.py modified in PR(s): Drop type specs for DQMOffline/Trigger #36783

cmsbuild · 2022-02-22T16:53:28Z

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

DQM/SiStripMonitorClient (dqm)
DQMOffline/Trigger (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@fioriNTU, @arossi83, @trocino, @HuguesBrun, @hdelanno, @missirol, @sroychow, @jhgoh, @calderona, @sscruz, @Fedespring, @threus, @jandrea, @idebruyn, @mmusich, @venturia, @mtosi, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

tvami · 2022-02-22T16:53:58Z

@cmsbuild , please test

cmsbuild · 2022-02-22T18:22:20Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a15df/22584/summary.html
COMMIT: 20080e0
CMSSW: CMSSW_12_3_X_2022-02-22-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37033/22584/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMOfflineConfiguration_10 had ERRORS
---> test TestDQMOfflineConfiguration_210 had ERRORS
---> test TestDQMOfflineConfiguration_220 had ERRORS
---> test TestDQMOfflineConfiguration_20 had ERRORS
and more ...

RelVals

138.4

----- Begin Fatal Exception 22-Feb-2022 18:16:54 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=METMonitor label='PFMET110_PFMHT110_IDTight_METmonitoring'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'stage2'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

138.5

----- Begin Fatal Exception 22-Feb-2022 18:18:40 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=METMonitor label='PFMET110_PFMHT110_IDTight_METmonitoring'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'stage2'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

139.001

----- Begin Fatal Exception 22-Feb-2022 18:23:49 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=METMonitor label='PFMET110_PFMHT110_IDTight_METmonitoring'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'stage2'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

136.7801136.7801_RunHLTPhy2017B_AOD+RunHLTPhy2017B_AOD+DQMHLTonAOD_2017+HARVESTDQMHLTonAOD_2017/step2_RunHLTPhy2017B_AOD+RunHLTPhy2017B_AOD+DQMHLTonAOD_2017+HARVESTDQMHLTonAOD_2017.log
136.7803136.7803_RunHLTPhy2017B_RAWAOD+RunHLTPhy2017B_RAWAOD+DQMHLTonRAWAOD_2017+HARVESTDQMHLTonAOD_2017/step2_RunHLTPhy2017B_RAWAOD+RunHLTPhy2017B_RAWAOD+DQMHLTonRAWAOD_2017+HARVESTDQMHLTonAOD_2017.log
138.5138.5_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3/step2_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3.log

Expand to see more relval errors ...

cmsbuild · 2022-02-22T19:09:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37033/28465

This PR adds an extra 44KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQMOffline/Trigger/python/BPHMonitor_cfi.py modified in PR(s): Drop type specs for DQMOffline/Trigger #36783
- File DQMOffline/Trigger/python/JetMonitor_cfi.py modified in PR(s): Drop type specs for DQMOffline/Trigger #36783
- File DQMOffline/Trigger/python/METMonitor_cfi.py modified in PR(s): Drop type specs for DQMOffline/Trigger #36783
- File DQMOffline/Trigger/python/MuonMonitor_cfi.py modified in PR(s): Drop type specs for DQMOffline/Trigger #36783

cmsbuild · 2022-02-22T19:09:32Z

Pull request #37033 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

tvami · 2022-02-22T19:11:17Z

@cmsbuild , please test

mmusich · 2022-02-23T08:16:35Z

@tvami I think the problem is that once you create the dict for changing the stage2 parameter in the configuration, it expects all the other ones to be defined as well.
e.g.:

cmsrel CMSSW_12_3_X_2022-02-22-2300/src/
cd CMSSW_12_3_X_2022-02-22-2300
cmsenv
git-fetch-user tvami
git checkout l1Stage1DQMmodule
git cms-addpkg DQM/SiStripMonitorClient DQMOffline/Trigger
scramv1 b -j 20
voms-proxy-init -voms cms
runTheMatrix.py -l 138.4
more138.4_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3/step2_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3.log

gives:

----- Begin Fatal Exception 23-Feb-2022 09:00:15 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MuonMonitor label='TrkMu12_DoubleTrkMu5NoFiltersNoVtx_monitoring'
Exception Message:
MissingParameter: Parameter 'l1tAlgBlkInputTag' not found.
----- End Fatal Exception -------------------------------------------------

if you add the parameter in the configuration, likely also the fillDescriptions needs to be updated....

… fillDescriptions

mmusich · 2022-02-23T10:33:56Z

tvami#5 this seems to make it go through.

add rest of parameters for GenericTriggerEventFlag in configuration / fillDescriptions

cmsbuild · 2022-02-23T14:58:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37033/28485

This PR adds an extra 44KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQMOffline/Trigger/python/BPHMonitor_cfi.py modified in PR(s): Drop type specs for DQMOffline/Trigger #36783
- File DQMOffline/Trigger/python/JetMonitor_cfi.py modified in PR(s): Drop type specs for DQMOffline/Trigger #36783
- File DQMOffline/Trigger/python/METMonitor_cfi.py modified in PR(s): Drop type specs for DQMOffline/Trigger #36783
- File DQMOffline/Trigger/python/MuonMonitor_cfi.py modified in PR(s): Drop type specs for DQMOffline/Trigger #36783

cmsbuild · 2022-02-23T14:59:07Z

Pull request #37033 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

tvami · 2022-02-23T15:00:48Z

@cmsbuild , please test

cmsbuild · 2022-02-23T20:23:12Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a15df/22620/summary.html
COMMIT: df23d7c
CMSSW: CMSSW_12_3_X_2022-02-23-0800/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37033/22620/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 4001143
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4001113
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

tvami · 2022-02-23T21:59:09Z

Yay, diffs show no changes, that's great I guess that means these tags were not really used anywhere indeed, otherwise I'd have expected at least some changes in the plots.

jfernan2 · 2022-02-24T09:24:07Z

+1

cmsbuild · 2022-02-24T09:24:32Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

tvami · 2022-02-24T17:06:54Z

@cms-sw/orp-l2 can we please merge this in the 2300 IB? Just so I can remove the tag from the GT in that IB

perrotta · 2022-02-24T18:13:30Z

+1

Change DQM modules to use stage-2 L1T

20080e0

cmsbuild added this to the CMSSW_12_3_X milestone Feb 22, 2022

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures tests-pending labels Feb 22, 2022

tvami mentioned this pull request Feb 22, 2022

Cleanning up depricating L1 O2O Tags from the CondDB cms-l1t-offline/cmssw#958

Open

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 22, 2022

cmsbuild added tests-started and removed tests-pending labels Feb 22, 2022

cmsbuild added tests-rejected and removed tests-started labels Feb 22, 2022

tvami mentioned this pull request Feb 22, 2022

Old L1T tags consumed in DQM modules #37016

Closed

Add stage2 to fillDescribtion

e41e6ea

cmsbuild added code-checks-pending tests-pending and removed tests-rejected code-checks-approved labels Feb 22, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 22, 2022

cmsbuild removed the tests-pending label Feb 22, 2022

cmsbuild mentioned this pull request Feb 23, 2022

Drop type specs for DQMOffline/Trigger #36783

Closed

add rest of parameters for GenericTriggerEventFlag in configuration /…

059869d

… fillDescriptions

mmusich mentioned this pull request Feb 23, 2022

add rest of parameters for GenericTriggerEventFlag in configuration / fillDescriptions tvami/cmssw#5

Merged

Merge pull request #5 from mmusich/l1Stage1DQMmodule

df23d7c

add rest of parameters for GenericTriggerEventFlag in configuration / fillDescriptions

cmsbuild added code-checks-pending and removed code-checks-approved labels Feb 23, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 23, 2022

cmsbuild added tests-started and removed tests-pending labels Feb 23, 2022

cmsbuild added tests-approved and removed tests-started labels Feb 23, 2022

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Feb 24, 2022

cmsbuild added orp-approved and removed orp-pending labels Feb 24, 2022

cmsbuild merged commit 5910b0e into cms-sw:master Feb 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change DQM modules to use stage-2 L1T #37033

Change DQM modules to use stage-2 L1T #37033

tvami commented Feb 22, 2022

cmsbuild commented Feb 22, 2022

cmsbuild commented Feb 22, 2022

tvami commented Feb 22, 2022

cmsbuild commented Feb 22, 2022

cmsbuild commented Feb 22, 2022

cmsbuild commented Feb 22, 2022

tvami commented Feb 22, 2022

mmusich commented Feb 23, 2022

mmusich commented Feb 23, 2022

cmsbuild commented Feb 23, 2022

cmsbuild commented Feb 23, 2022

tvami commented Feb 23, 2022

cmsbuild commented Feb 23, 2022

tvami commented Feb 23, 2022

jfernan2 commented Feb 24, 2022

cmsbuild commented Feb 24, 2022

tvami commented Feb 24, 2022

perrotta commented Feb 24, 2022

Change DQM modules to use stage-2 L1T #37033

Change DQM modules to use stage-2 L1T #37033

Conversation

tvami commented Feb 22, 2022

PR description:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Feb 22, 2022

cmsbuild commented Feb 22, 2022

tvami commented Feb 22, 2022

cmsbuild commented Feb 22, 2022

Unit Tests

RelVals

RelVals-INPUT

cmsbuild commented Feb 22, 2022

cmsbuild commented Feb 22, 2022

tvami commented Feb 22, 2022

mmusich commented Feb 23, 2022

mmusich commented Feb 23, 2022

cmsbuild commented Feb 23, 2022

cmsbuild commented Feb 23, 2022

tvami commented Feb 23, 2022

cmsbuild commented Feb 23, 2022

Comparison Summary

tvami commented Feb 23, 2022

jfernan2 commented Feb 24, 2022

cmsbuild commented Feb 24, 2022

tvami commented Feb 24, 2022

perrotta commented Feb 24, 2022