Drop type specs for DQMOffline/Trigger #36783

NiharSaha · 2022-01-23T08:47:58Z

PR description:

Drop type specs in DQMOffline/Trigger python configuration files.

Central DQM migration campaign for drop type spces following
https://cms-sw.github.io/cms_coding_rules.html#6--packaging-rules-1
and update the safer syntax for existing parameters like: (1) drop type specifications where the original parameter exists. (2) using "clone" instead of "deepcopy" (3) move all parameters inside the clone

PR validation:

Tested in CMSSW_12_3_X via runTheMatrix.py -l limited -i all --ibeos

cmsbuild · 2022-01-23T08:54:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36783/27923

This PR adds an extra 88KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQMOffline/Trigger/python/BTaggingMonitor_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/DiJetMonitor_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/HTMonitor_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/HiggsMonitoring_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/METMonitor_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/METplusTrackMonitor_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/MjjMonitor_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/MssmHbbMonitoring_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/MuonMonitor_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/PhotonMonitor_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/RazorMonitor_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/SoftdropMonitor_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/SusyMonitor_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465

cmsbuild · 2022-01-23T08:55:07Z

A new Pull Request was created by @NiharSaha (Nihar Ranjan Saha) for master.

It involves the following packages:

DQMOffline/Trigger (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@sscruz, @missirol, @mtosi, @Fedespring, @calderona, @HuguesBrun, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

missirol · 2022-01-23T12:06:38Z

DQMOffline/Trigger/python/B2GMonitoring_cff.py

+PFHT1050_Mjjmonitoring = hltMjjmonitoring.clone(
+    FolderName = 'HLT/B2G/PFHT1050',
+    #numGenericTriggerEventPSet.hltPaths == ["HLT_PFHT1050_v*"],
+    jets = "ak8PFJetsPuppi",
+    jetSelection = "pt > 200 && eta < 2.4"
+)
 PFHT1050_Mjjmonitoring.numGenericTriggerEventPSet.hltPaths = cms.vstring("HLT_PFHT1050_v*")


Suggested change

PFHT1050_Mjjmonitoring = hltMjjmonitoring.clone(

FolderName = 'HLT/B2G/PFHT1050',

#numGenericTriggerEventPSet.hltPaths == ["HLT_PFHT1050_v*"],

jets = "ak8PFJetsPuppi",

jetSelection = "pt > 200 && eta < 2.4"

)

PFHT1050_Mjjmonitoring.numGenericTriggerEventPSet.hltPaths = cms.vstring("HLT_PFHT1050_v*")

PFHT1050_Mjjmonitoring = hltMjjmonitoring.clone(

FolderName = 'HLT/B2G/PFHT1050',

jets = "ak8PFJetsPuppi",

jetSelection = "pt > 200 && eta < 2.4",

numGenericTriggerEventPSet = dict(hltPaths = ["HLT_PFHT1050_v*"])

)

This should work, too (but I haven't tested it). If not, one should at least be able to do

PFHT1050_Mjjmonitoring.numGenericTriggerEventPSet.hltPaths = ["HLT_PFHT1050_v*"]

This comment applies to various other places in this PR, but it is optional (obviously, the review is up to DQM experts).

Thanks @missirol indeed the dict solution is the recommended one I believe

Okay. Actually, dict was not effective in some previous PRs, and that's why I didn't consider it in this PR. Will consider in this PR. Thank you for the suggestions.

cmsbuild · 2022-01-24T09:58:59Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36783/27925

This PR adds an extra 88KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQMOffline/Trigger/python/BTaggingMonitor_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/DiJetMonitor_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/HTMonitor_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/HiggsMonitoring_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/METMonitor_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/METplusTrackMonitor_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/MjjMonitor_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/MssmHbbMonitoring_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/MuonMonitor_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/PhotonMonitor_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/RazorMonitor_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/SoftdropMonitor_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465
- File DQMOffline/Trigger/python/SusyMonitor_cfi.py modified in PR(s): Remove Event Interpretation (EI) from relval steps #36465

cmsbuild · 2022-01-24T09:59:21Z

Pull request #36783 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

cmsbuild · 2022-01-24T14:08:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36783/27926

This PR adds an extra 20KB to repository

cmsbuild · 2022-01-24T14:08:52Z

Pull request #36783 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

cmsbuild · 2022-01-24T14:49:02Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36783/27929

This PR adds an extra 164KB to repository

cmsbuild · 2022-01-24T14:49:25Z

Pull request #36783 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

cmsbuild · 2022-03-02T18:04:47Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36783/28639

This PR adds an extra 352KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQMOffline/Trigger/python/BPHMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/BTaggingMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/DiJetMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/HTMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/HiggsMonitoring_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/JetMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/LepHTMonitor_cff.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/METMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/METplusTrackMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/MjjMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/MssmHbbBtagTriggerMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/MssmHbbMonitoring_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/MuonMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/NoBPTXMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/ObjMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/PhotonMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/RazorMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/SiStrip_OfflineMonitoring_cff.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/SoftdropMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/SusyMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084

cmsbuild · 2022-03-02T18:05:11Z

Pull request #36783 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

cmsbuild · 2022-03-02T18:43:59Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36783/28641

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQMOffline/Trigger/python/BPHMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/BTaggingMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/DiJetMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/HTMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/HiggsMonitoring_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/JetMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/LepHTMonitor_cff.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/METMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/METplusTrackMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/MjjMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/MssmHbbBtagTriggerMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/MssmHbbMonitoring_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/MuonMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/NoBPTXMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/ObjMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/PhotonMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/RazorMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/SiStrip_OfflineMonitoring_cff.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/SoftdropMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084
- File DQMOffline/Trigger/python/SusyMonitor_cfi.py modified in PR(s): migration to DCSRecord of GenericTriggerEventFlag #37084

cmsbuild · 2022-03-02T18:44:28Z

Pull request #36783 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

cmsbuild · 2022-03-03T09:12:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36783/28652

This PR adds an extra 380KB to repository

cmsbuild · 2022-03-03T09:12:50Z

Pull request #36783 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

cmsbuild · 2022-03-03T10:29:07Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36783/28656

This PR adds an extra 372KB to repository

cmsbuild · 2022-03-03T10:29:36Z

Pull request #36783 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

cmsbuild added this to the CMSSW_12_3_X milestone Jan 23, 2022

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures tests-pending labels Jan 23, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 23, 2022

missirol reviewed Jan 23, 2022

View reviewed changes

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 24, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 24, 2022

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 24, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 24, 2022

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 24, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 24, 2022

Drop type specs for Trigger

3118fc0

Update HiggsMonitoring_cff.py

1a2186c

cmsbuild added code-checks-pending and removed code-checks-approved labels Mar 2, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 2, 2022

Update BPHMonitor_cfi.py

ac29d26

cmsbuild added code-checks-pending and removed code-checks-approved labels Mar 2, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 2, 2022

Merge branch 'master' into CMSSW_12_3_X_Trigger

29fc854

cmsbuild added code-checks-pending and removed code-checks-approved labels Mar 3, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 3, 2022

Update VBFMETMonitor_cff.py

1c46cff

cmsbuild added code-checks-pending and removed code-checks-approved labels Mar 3, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 3, 2022

cmsbuild mentioned this pull request Mar 3, 2022

Drop type specs for Trigger #37133

Merged

NiharSaha closed this Mar 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop type specs for DQMOffline/Trigger #36783

Drop type specs for DQMOffline/Trigger #36783

NiharSaha commented Jan 23, 2022

cmsbuild commented Jan 23, 2022

cmsbuild commented Jan 23, 2022

missirol Jan 23, 2022

jfernan2 Jan 23, 2022

NiharSaha Jan 24, 2022

cmsbuild commented Jan 24, 2022

cmsbuild commented Jan 24, 2022

cmsbuild commented Jan 24, 2022

cmsbuild commented Jan 24, 2022

cmsbuild commented Jan 24, 2022

cmsbuild commented Jan 24, 2022

cmsbuild commented Mar 2, 2022

cmsbuild commented Mar 2, 2022

cmsbuild commented Mar 2, 2022

cmsbuild commented Mar 2, 2022

cmsbuild commented Mar 3, 2022

cmsbuild commented Mar 3, 2022

cmsbuild commented Mar 3, 2022

cmsbuild commented Mar 3, 2022

Drop type specs for DQMOffline/Trigger #36783

Drop type specs for DQMOffline/Trigger #36783

Conversation

NiharSaha commented Jan 23, 2022

PR description:

PR validation:

cmsbuild commented Jan 23, 2022

cmsbuild commented Jan 23, 2022

missirol Jan 23, 2022

Choose a reason for hiding this comment

jfernan2 Jan 23, 2022

Choose a reason for hiding this comment

NiharSaha Jan 24, 2022

Choose a reason for hiding this comment

cmsbuild commented Jan 24, 2022

cmsbuild commented Jan 24, 2022

cmsbuild commented Jan 24, 2022

cmsbuild commented Jan 24, 2022

cmsbuild commented Jan 24, 2022

cmsbuild commented Jan 24, 2022

cmsbuild commented Mar 2, 2022

cmsbuild commented Mar 2, 2022

cmsbuild commented Mar 2, 2022

cmsbuild commented Mar 2, 2022

cmsbuild commented Mar 3, 2022

cmsbuild commented Mar 3, 2022

cmsbuild commented Mar 3, 2022

cmsbuild commented Mar 3, 2022